Update mdanter/ecc to accept v1 and unblock php 8 upgrade #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanter/ecc v0.5 requires php ^7.0, the v1 handle php 8 and there is no breaking change Diff between v0.5.2 and v1.0.0
|
@afk11 would it be possible to merge this PR ? It's our last blocker to upgrade to PHP 8 |
itinance
added a commit
to itinance/bitcoin-php
that referenced
this pull request
Aug 1, 2021
itinance
added a commit
to itinance/bitcoin-php
that referenced
this pull request
Aug 1, 2021
|
We had to fork; https://github.com/ProtonMail/bitcoin-php and |
Thanks you saved me the pain, Im working on a package that requires https://github.com/kornrunner/php-keccak and it require mdanter/eec v1 and worse my php version was 8.4. Tnanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdanter/ecc v0.5 requires php ^7.0, the v1 handle php 8 and there is no breaking change
Diff between v0.5.2 and v1.0.0: phpecc/phpecc@v0.5.2...v1.0.0
Release note: https://github.com/phpecc/phpecc/blob/master/doc/release-notes-1.0.0.md